zturner added a comment. In https://reviews.llvm.org/D39436#911264, @jingham wrote:
> Zachary's suggestion is better than adding regex patterns to FileSpec, but I > still don't like the idea of encoding option types in the option values. > > Moreover, this doesn't really apply to the main use of -f - file & line > breakpoints. The only plausible use for a source file filter for file & line > breakpoints is when you want to restrict breaking on inlined code to a subset > of the files that inline it. But in that case you would want a separate > option, since you need to specify the inlined file = with the -f option - and > the inlining files - with some other option. > > Wouldn't it be better to add a --source-file-regex option, pick some free > single letter, and use that if you want to provide a pattern for the "-p" > breakpoint option. Then we could also use it when specifying some other file > filter. Actually now that you mention it, yea this option seems to only make sense when paired with `-p`. I actually explicitly don't like the idea of being able to set a breakpoint in a bunch of random files that share nothing in common other than some characters in the filename. I can't think of a reasonable use case for that. Even combining it with `-p`, maybe the real solution here is to //rename// `all-files` to `file-pattern`. The only usage of `--all-files` is in conjunction with `-p`, so changing the name of the flag to `file-pattern` would be low impact. And //not// changing the name would mean you have one option which essentially has no real value, since `--file-pattern=.*` would be identical to `--all-files`, and there would be no value to ever specifying `--all-files` over `--file-pattern` https://reviews.llvm.org/D39436 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
