Ahh, sorry. While I feel strongly about 1 long term, going from 4 -> 2 is already a win, so I see no reason to block this over that. We can then work on going from 2 -> 1 later.
On Thu, Oct 26, 2017 at 4:57 PM Pavel Labath <lab...@google.com> wrote: > I haven't put this in yet. I was still waiting for a reaction from > Zachary about the two cmake vars, as he felt pretty strongly about > unifying to one. (I didn't want to do that as I would have to write > code for transforming /usr/bin/arm-linux-gnu-gcc-4.7 (and likes) into > /usr/bin/arm-linux-gnu-g++-4.7, which would probably end up very > ugly). > > On 26 October 2017 at 16:50, Zachary Turner <ztur...@google.com> wrote: > > I think you now need to use `-DLLDB_TEST_C_COMPILER` and > > `-DLLDB_TEST_CXX_COMPILER` > > > > On Thu, Oct 26, 2017 at 4:40 PM Paul Robinson via Phabricator > > <revi...@reviews.llvm.org> wrote: > >> > >> probinson added a comment. > >> > >> Has this gone in? I'm wondering because I starting playing with the > >> monorepo, ran cmake with -DLLDB_TEST_COMPILER=$PWD/bin/clang, and > today's > >> test failure seems to be trying to build the test program with the > system > >> compiler (gcc) rather than my copy of clang. But it looks like you're > >> deprecating LLDB_TEST_COMPILER? > >> > >> > >> https://reviews.llvm.org/D39215 > >> > >> > >> > > >
_______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
