================
@@ -89,8 +89,11 @@ Status
MinidumpFileBuilder::AddHeaderAndCalculateDirectories() {
"Failed to fill in header and directory "
"sections. Written / Expected (%" PRIx64 " / %" PRIx64 ")",
new_offset, m_saved_data_size);
-
return error;
+ if (error.Fail())
+ return error;
----------------
clayborg wrote:
No, we should implement the `lldb_private::StructuredData::ObjectSP
Process::GetLoadedDynamicLibrariesInfos()` virtual method in ProcessMinidump
and return a structured data that describes where everything is loaded. Then
have the POSIX dynamic loader call this method on the process object and see if
it returns anything. If it does, then we use this as the truth, else we
discover the shared libraries using the existing code in the POSIX dynamic
loader.
https://github.com/llvm/llvm-project/pull/120166
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
