================
@@ -89,8 +89,11 @@ Status
MinidumpFileBuilder::AddHeaderAndCalculateDirectories() {
"Failed to fill in header and directory "
"sections. Written / Expected (%" PRIx64 " / %" PRIx64 ")",
new_offset, m_saved_data_size);
-
return error;
+ if (error.Fail())
+ return error;
----------------
clayborg wrote:
We should change all dynamic loaders to always check with the process via:
```
lldb_private::StructuredData::ObjectSP Process::GetLoadedDynamicLibrariesInfos()
```
This allows processes to tell the dynamic loaders where things are loaded in
case they know, like in the case of minidumps. So we can probably make the
POSIX dynamic loader a bit smarter when it comes to dealing with core files.
https://github.com/llvm/llvm-project/pull/120166
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
