================
@@ -89,8 +89,11 @@ Status 
MinidumpFileBuilder::AddHeaderAndCalculateDirectories() {
         "Failed to fill in header and directory "
         "sections. Written / Expected (%" PRIx64 " / %" PRIx64 ")",
         new_offset, m_saved_data_size);
-
   return error;
+  if (error.Fail())
+    return error;
----------------
Jlalond wrote:

@clayborg Just so I follow, you're recommending we embed a structured data 
(really just Json) into a section? If so, I really like the proposal, because 
it allows us to have a fairly loose schema across Brakepad, Crashpad and LLDB.

https://github.com/llvm/llvm-project/pull/120166
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to