DhruvSrivastavaX wrote:

Okay sure. 
Thats not a problem Pavel, better to have it in smaller understandable pieces, 
so that it can be organised and reviewed properly. 

There are a couple of incoming code with such huge changes,  it will be good to 
adhere to this systematic approach. 

So, I will go ahead and modify this PR to drop a smaller piece of 
ObjectFileXCOFF.h and ObjectFileXCOFF.cpp instead, 
which can be reviewed easily (some base skeleton and declaration of parent 
virtual functions etc). 
Once that gets pulled in, I will build my next few PRs on that in order to 
complete these new additions. 
Will also try to add relevant test cases. 

Thanks!

https://github.com/llvm/llvm-project/pull/111814
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to