zturner accepted this revision. zturner added a comment. This revision is now accepted and ready to land.
I think this is ready to go in. You probably noticed that this took a long time to work out all the issues with. In the future if there's any way you could break things up into smaller patches, you will probably end up getting lots of small patches in in a shorter total time than one large patch. Even if it just means fixing all the Unicode issues in file X, and then in file Y in a separate patch, etc. Anyway, thanks for seeing this through to the end! http://reviews.llvm.org/D17107 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
