cameron314 added inline comments. ================ Comment at: tools/lldb-mi/MIUtilFileStd.cpp:234-241 @@ -223,11 +233,10 @@ - FILE *pTmp = nullptr; - pTmp = ::fopen(vFileNamePath.c_str(), "wb"); + FILE *pTmp = lldb_private::FileSystem::Fopen(vFileNamePath.c_str(), "wb"); if (pTmp != nullptr) { ::fclose(pTmp); return true; } return false; } ---------------- Seems this breaks the LLDB build on OS X. Sean has reverted this part, but it should be using the `#ifdef` that was there in the earlier version of the patch:
#ifdef _WIN32 std::wstring path; if (!llvm::ConvertUTF8toWide(vFileNamePath.c_str(), path)) return false; pTmp = ::_wfopen(path.c_str(), L"wb"); #else pTmp = ::fopen(vFileNamePath.c_str(), "wb"); #endif http://reviews.llvm.org/D17107 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits