paulherman added a comment.

I believe that the approach of CompilerDeclContext::FindDecls could be better. 
But then this kind of forces CompilerDeclContext to inherit CompilerDecl (a 
function is both a DeclContext and a Decl) and I believe that creating a class 
for each possible entity is an overkill.

I started looking at SymbolFileDWARF. In order to not have "clang::___", I 
believe that ParseVariableDIE and ParseFunctionBlocks should be moved to 
DWARFASTParser.

I don't really understand what Sean and Jim mean. I believe that ClangASTSource 
implements the interface ExternalASTSource and ClangExpressionDeclMap (which 
does the actual search) inherits ClangASTSource, so it should be already 
alright...?


http://reviews.llvm.org/D12658



_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to