On 06/01/2014 11:48 AM, Michael Neuling wrote:
> On Fri, 2014-05-30 at 17:40 +0530, Anshuman Khandual wrote:
>> This patch enables support for hardware instruction breakpoints on POWER8
>> with
>> the help of a new register called CIABR (Completed Instruction Address
>> Breakpoint
>> Register). With this patch, single hardware instruction breakpoint can be
>> added
>> and cleared during any active xmon debug session. This hardware based
>> instruction
>> breakpoint mechanism works correctly along with the existing TRAP based
>> instruction
>> breakpoints available on xmon. Example usage as follows.
>
> Have you actually tried this on a guest?
>
Yeah on a guest which runs on PVM.
> Please also compile with a range of configs. It doesn't compile with
> ppc64e_defconfig.
Yeah. Need to change the way we get the "plapr_set_ciabr" function from
plpar_wrappers.h
header file. Will add this hunk of code in "xmon.h" header and remove the
CONFIG_PPC64 ifdef
code from the function write_ciabr.
+#ifdef CONFIG_PPC_BOOK3S_64
+#include <asm/plpar_wrappers.h>
+#else
+static inline long plapr_set_ciabr(unsigned long ciabr) {return 0;};
+#endif
>
> In file included from
> /scratch/mikey/src/linux-ozlabs/arch/powerpc/xmon/xmon.c:51:0:
> /scratch/mikey/src/linux-ozlabs/arch/powerpc/include/asm/plpar_wrappers.h: In
> function 'get_cede_latency_hint':
> /scratch/mikey/src/linux-ozlabs/arch/powerpc/include/asm/plpar_wrappers.h:26:9:
> error: 'struct paca_struct' has no member named 'lppaca_ptr'
> /scratch/mikey/src/linux-ozlabs/arch/powerpc/include/asm/plpar_wrappers.h: In
> function 'set_cede_latency_hint':
> /scratch/mikey/src/linux-ozlabs/arch/powerpc/include/asm/plpar_wrappers.h:31:2:
> error: 'struct paca_struct' has no member named 'lppaca_ptr'
> /scratch/mikey/src/linux-ozlabs/arch/powerpc/include/asm/plpar_wrappers.h: In
> function 'plpar_page_set_loaned':
> /scratch/mikey/src/linux-ozlabs/arch/powerpc/include/asm/plpar_wrappers.h:98:2:
> error: implicit declaration of function 'cmo_get_page_size'
> [-Werror=implicit-function-declaration]
> cc1: all warnings being treated as errors
>
>> - (bp->enabled & BP_IABR)? "inst": "trap");
>> + (bp->enabled & (BP_IABR | BP_CIABR))?
>> + "inst": "trap");
>
> Git complains about whitespace issues here. Spaces before tabs.
Will take care of this next version.
_______________________________________________
Linuxppc-dev mailing list
Linuxppc-dev@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/linuxppc-dev
