On Nov 7, 2011, at 2:32 AM, Roy Zang wrote: > P1023 external IRQ[4:6, 11] do not pin out, but the interrupts are > shared with PCIe controller. > The silicon internally ties the interrupts to L, so change the > IRQ[4:6,11] to high level sensitive for PCIe. > > Signed-off-by: Roy Zang <tie-fei.z...@freescale.com> > --- > arch/powerpc/boot/dts/p1023rds.dts | 8 ++++---- > 1 files changed, 4 insertions(+), 4 deletions(-) > > diff --git a/arch/powerpc/boot/dts/p1023rds.dts > b/arch/powerpc/boot/dts/p1023rds.dts > index d9b7767..66bf804 100644 > --- a/arch/powerpc/boot/dts/p1023rds.dts > +++ b/arch/powerpc/boot/dts/p1023rds.dts > @@ -490,9 +490,9 @@ > interrupt-map-mask = <0xf800 0 0 7>; > interrupt-map = < > /* IDSEL 0x0 */ > - 0000 0 0 1 &mpic 4 1 > - 0000 0 0 2 &mpic 5 1 > - 0000 0 0 3 &mpic 6 1 > + 0000 0 0 1 &mpic 4 2 > + 0000 0 0 2 &mpic 5 2 > + 0000 0 0 3 &mpic 6 2 > 0000 0 0 4 &mpic 7 1 > >; > ranges = <0x2000000 0x0 0xa0000000 > @@ -532,7 +532,7 @@ > 0000 0 0 1 &mpic 8 1 > 0000 0 0 2 &mpic 9 1 > 0000 0 0 3 &mpic 10 1 > - 0000 0 0 4 &mpic 11 1 > + 0000 0 0 4 &mpic 11 2 > >; > ranges = <0x2000000 0x0 0x80000000 > 0x2000000 0x0 0x80000000 > -- > 1.6.0.6 >
Should be setting ALL PCIe interrupts to '2'? As I think in general we say these PCIe are 'active high'. The only reason I would think we would NOT do this is if they are shared with some external device that is 'active low'. If so we should comment that somewhere (maybe in the .dts, maybe just in the commit message). - k _______________________________________________ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev
