Hi Ben, Thanks again for your comments. > Same goes with the SDR register definitions. Prefix them with the SOC > name but don't make them conditionally compiled.
I will add the base address in the Device tree, and make all register definitions based on offset from the base in the next version of this patch. > Also, this coalescing option, while it makes sense to have a CONFIG > option to compile in the support for it or not, the choice to use > coalescing or not should be done at runtime. Same goes with the various > thresholds which should be runtime configurable. Thanks for this comment. I will hookup ethtool with the EMAC driver, but the MAL driver will come up with default coalesce options (as defined in the appropriate defconfig file). The user will be able to change these parameters as needed using ethtool. I will get all the changes in place in the next version of this patch. Thanks Prodyut _______________________________________________ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev
