On Thu, 1 May 2025 at 09:43, Luis Gerhorst <luis.gerho...@fau.de> wrote: > > This is required to catch the errors later and fall back to a nospec if > on a speculative path. > > Eliminate the regs variable as it is only used once and insn_idx is not > modified in-between the definition and usage. > > Still pass insn simply to match the other check_*() functions. As Eduard > points out [1], insn is assumed to correspond to env->insn_idx in many > places (e.g, __check_reg_arg()). > > Move code into do_check_insn(), replace > * "continue" with "return 0" after modifying insn_idx > * "goto process_bpf_exit" with "return PROCESS_BPF_EXIT" > * "do_print_state = " with "*do_print_state = " > > [1] > https://lore.kernel.org/all/293dbe3950a782b8eb3b87b71d7a967e120191fd.ca...@gmail.com/ > > Signed-off-by: Luis Gerhorst <luis.gerho...@fau.de> > Acked-by: Henriette Herzog <henriette.her...@rub.de> > Cc: Maximilian Ott <o...@cs.fau.de> > Cc: Milan Stephan <milan.step...@fau.de> > ---
Acked-by: Kumar Kartikeya Dwivedi <mem...@gmail.com>