On Sun, Jul 27, 2008 at 06:56:49PM -0700, Trent Piepho wrote: > On Sun, 27 Jul 2008, Stephen Rothwell wrote: > > On Sat, 26 Jul 2008 20:08:57 -0600 Grant Likely <[EMAIL PROTECTED]> wrote: > >> On Fri, Jul 25, 2008 at 02:01:44PM -0700, Trent Piepho wrote: > >>> The default_trigger fields of struct gpio_led and thus struct led_classdev > >>> are pretty much always assigned from a string literal, which means the > >>> string can't be modified. Which is fine, since there is no reason to > >>> modify the string and in fact it never is. > >>> > >>> But they should be marked const to prevent such code from being added, to > >>> prevent warnings if -Wwrite-strings is used and when assigned from a > >>> constant string other than a string literal (which produces a warning > >>> under > >>> current kernel compiler flags), and for general good coding practices. > >>> > >>> Signed-off-by: Trent Piepho <[EMAIL PROTECTED]> > >> Acked-by: Grant Likely <[EMAIL PROTECTED]> > > > > I would ack this as well, except I am not sure what tree this patch is > > against. In the current powerpc next tree, > > It was against powerpc next from Jul 22nd, current at the time I made the > patch. It looks like that file has changed in the last few days. There is a > patch from Anton Vorontsov, "leds: mark led_classdev.default_trigger as > const", which adds const to one of the structs I modified, but doesn't get the > other one (struct gpio_led).
Yes, I posted the patch for my version of OF GPIO LEDs, which didn't use struct gpio_led's default_trigger. -- Anton Vorontsov email: [EMAIL PROTECTED] irc://irc.freenode.net/bd2 _______________________________________________ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev
