On Mon, Jul 28, 2008 at 10:02:04PM +0400, Anton Vorontsov wrote:
> On Mon, Jul 28, 2008 at 11:09:14AM -0600, Grant Likely wrote:
> > I'd rather see the device tree provide 'hints' toward the expected usage
> > and if a platform needs something specific, then the platform specific
> > code should setup the trigger.
> >
> > Regardless, any hints provided by the binding must be documented. In
> > most cases the gpio-leds driver should be able to figure out which trigger
> > to bind without platform code intervention.
>
> Maybe we can encode leds into devices themselves, via phandles?
>
> E.g.
>
> [EMAIL PROTECTED] {
> compatible = "fsl,sata";
> leds = <&red_led>;
> };
I like that idea! That neatly solves the problem for many use cases.
> And then the OF GPIO LEDs driver could do something like:
>
> char *ide_disk_trigger_compatibles[] = {
> "fsl,sata",
> "ide-generic",
> ...
> };
>
> for_each_node_with_leds_property(node, led_phandle) {
> if (if_ide_disk_compatible(node)) {
> struct gpio_led *led = phandle_to_led(led_phandle);
>
> led->default_trigger = "ide-disk";
> }
> }
I'm not sure what would be best for implementation details, but
implementation details can easily be changed.
>
> --
> Anton Vorontsov
> email: [EMAIL PROTECTED]
> irc://irc.freenode.net/bd2
_______________________________________________
Linuxppc-dev mailing list
Linuxppc-dev@ozlabs.org
https://ozlabs.org/mailman/listinfo/linuxppc-dev
