Re: [PATCH v2 4/6] [POWERPC] QE: implement support for the GPIO LIB API

[Timur Tabi]

Anton Vorontsov wrote:

> +   Example:
> +     qe_pio_a: [EMAIL PROTECTED] {
> +             #gpio-cells = <2>;
> +             compatible = "fsl,mpc8360-qe-pario-bank",
> +                          "fsl,mpc8323-qe-pario-bank";

I know this is an example, but would we ever include both compatible strings in
one DTS?  Isn't the norm something like:

"fsl,mpc8360-qe-pario-bank", "fsl,qe-pario-bank";

I.e. specific version, then generic version?

Otherwise, every time we introduce a new QE part, we'll have to update *every*
QE-enabled device tree *and* the QE gpio driver.

> +static int qe_gpio_get(struct gpio_chip *gc, unsigned int gpio)
> +{
> +     struct of_mm_gpio_chip *mm_gc = to_of_mm_gpio_chip(gc);
> +     struct qe_pio_regs __iomem *regs = mm_gc->regs;
> +     u32 pin_mask = 1 << (QE_PIO_PINS - 1 - gpio);
> +
> +     return in_be32(&regs->cpdata) & pin_mask;
> +}

Return value should be "u32", not "int".

-- 
Timur Tabi
Linux kernel developer at Freescale
_______________________________________________
Linuxppc-dev mailing list
Linuxppc-dev@ozlabs.org
https://ozlabs.org/mailman/listinfo/linuxppc-dev