On Tue, Apr 29, 2008 at 02:57:34PM -0500, Timur Tabi wrote: > Anton Vorontsov wrote: > > This patch adds a function to the qe_lib to setup QE USB clocks routing. > > To setup clocks safely, cmxgcr register needs locking, so I just reused > > ucc_lock since it was used only to protect cmxgcr. > > > > The idea behind placing clocks routing functions into the qe_lib is that > > later we'll hopefully switch to the generic Linux Clock API, thus, for > > example, FHCI driver may be used for QE and CPM chips without nasty #ifdefs. > > > > This patch also fixes QE_USB_RESTART_TX command definition in the qe.h. > > > > Signed-off-by: Anton Vorontsov <[EMAIL PROTECTED]> > > Acked-By: Timur Tabi <[EMAIL PROTECTED]>
Much thanks for the review and Acks. > Anton, please be sure to CC: me on any QE library patches you send out. Sorry about that. I actually know that QE changes should be Cc: you, but I always forget this. :-/ I should automate Ccing, someday. -- Anton Vorontsov email: [EMAIL PROTECTED] irc://irc.freenode.net/bd2 _______________________________________________ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev
