On Wed, Apr 30, 2008 at 05:50:42PM -0500, Timur Tabi wrote:
> Anton Vorontsov wrote:
> 
> > Per Grant Likely's comments, "fsl,qe-pario-bank" considered as a made up
> > stuff. MPC8323 is the first QE chip, so every next QE chips should be
> > compatible.
> 
> Ok.
> 
> >> Return value should be "u32", not "int".
> > 
> > gpio.h disagree
> > 
> > $ cat include/asm-generic/gpio.h  | grep \*get
> >         int                     (*get)(struct gpio_chip *chip,
> > 
> 
> In that case, perhaps you should return this:
> 
>       return in_be32(&regs->cpdata) & pin_mask ? 1 : 0;

What is the problem with returning (int)(u32 & u32) value?

You've asked to remove "!!" stuff and now purposing exactly the
same... :-?

-- 
Anton Vorontsov
email: [EMAIL PROTECTED]
irc://irc.freenode.net/bd2
_______________________________________________
Linuxppc-dev mailing list
Linuxppc-dev@ozlabs.org
https://ozlabs.org/mailman/listinfo/linuxppc-dev

Reply via email to