Joe Perches <j...@perches.com> writes: > On Tue, 2018-09-18 at 09:33 +0000, Christophe Leroy wrote: >> On the below patch, checkpatch reports >> >> WARNING: struct kgdb_arch should normally be const >> #127: FILE: arch/powerpc/kernel/kgdb.c:480: >> +struct kgdb_arch arch_kgdb_ops; >> >> But when I add 'const', I get compilation failure > > So don't add const. > > checkpatch is stupid. You are not. > > _Always_ take checkpatch bleats with very > large grains of salt. > > Perhaps send a patch to remove kgbd_arch > from scripts/const_structs.checkpatch as > it seems not ever to be const.
I think it could/should be const though, it just requires updating all arches. cheers
