> I'm interested in your opinion about that patch. You're also Cc'ed > to patch that using that feature. > > I know, currently that patch will conflict with GPIOLIB patches in -mm, > so this is only RFC.
The point of CONFIG_GENERIC_GPIO is to be *the* conditional used to tell whether that programming interface is available ... starting from "#include <asm/gpio.h>", and including all gpio_*() calls. So my first reaction is to not like this patch. It changes semantics in an incompatible way. And AFAICT, needlessly so. What other options did consider? Like, why not #ifdef the GPIO parts of that NAND driver, or have the whole driver depend on GENERIC_GPIO? - Dave _______________________________________________ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev