David Gibson wrote:
> On Tue, Nov 06, 2007 at 09:05:48PM +0100, Marian Balakowicz wrote:
>> Add device tree source file for TQM5200 board.
> [snip]
>> + [EMAIL PROTECTED] {
>> + device_type = "usb-ohci-be";
>
> This device_type is bogus. Remember having a valid device_type is the
> exception not the rule. Really the only common device_type values are
> "cpu", "memory", "network" and "serial".
Ok, rechecked this one, doesn't seem necessary, removed.
>> + [EMAIL PROTECTED] { // PSC1
>> + device_type = "serial";
>> + compatible = "mpc5200-psc-uart";
>> + port-number = <0>; // Logical port assignment
>
> I know you said this is still needed, but the driver really needs to
> be fixed. This is not a proper way of using the device tree for
> logical numbering.
True, driver needs fixing, but there are also other boards that use
that driver, and I am not able to test them right now. And, as I
recall Grant mentioned that he's working on straightening this up.
Cheers,
m.
_______________________________________________
Linuxppc-dev mailing list
Linuxppc-dev@ozlabs.org
https://ozlabs.org/mailman/listinfo/linuxppc-dev
