On Tue, Nov 06, 2007 at 09:05:48PM +0100, Marian Balakowicz wrote:
> Add device tree source file for TQM5200 board.
>
> Signed-off-by: Marian Balakowicz <[EMAIL PROTECTED]>
[snip]
> + [EMAIL PROTECTED] {
> + device_type = "usb-ohci-be";
This device_type is bogus. Remember having a valid device_type is the
exception not the rule. Really the only common device_type values are
"cpu", "memory", "network" and "serial".
> + compatible = "mpc5200-ohci","ohci-be";
> + reg = <1000 ff>;
> + interrupts = <2 6 0>;
> + interrupt-parent = <&mpc5200_pic>;
> + };
> +
> + [EMAIL PROTECTED] {
> + compatible = "mpc5200-bestcomm";
> + reg = <1200 80>;
> + interrupts = <3 0 0 3 1 0 3 2 0 3 3 0
> + 3 4 0 3 5 0 3 6 0 3 7 0
> + 3 8 0 3 9 0 3 a 0 3 b 0
> + 3 c 0 3 d 0 3 e 0 3 f 0>;
> + interrupt-parent = <&mpc5200_pic>;
> + };
> +
> + [EMAIL PROTECTED] {
> + compatible = "mpc5200-xlb";
> + reg = <1f00 100>;
> + };
> +
> + [EMAIL PROTECTED] { // PSC1
> + device_type = "serial";
> + compatible = "mpc5200-psc-uart";
> + port-number = <0>; // Logical port assignment
I know you said this is still needed, but the driver really needs to
be fixed. This is not a proper way of using the device tree for
logical numbering.
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
_______________________________________________
Linuxppc-dev mailing list
Linuxppc-dev@ozlabs.org
https://ozlabs.org/mailman/listinfo/linuxppc-dev
