On Fri, Nov 02, 2007 at 08:14:43AM +0100, Stefan Roese wrote: > This patch adds support for the 405EX to the new EMAC driver. Some as on > AXON, the 405EX handles the MDIO via the RGMII bridge.
Hi, This isn't feedback on your patch as much as on "new-emac" in general: Isn't this the case where there should really be device tree properties instead? If you had an "ibm,emac-has-axon-stacr" property in the device node, then you don't have to modify the driver for every new board out there. Same for the other device properties, of course. I thought this was what having the device tree was all about. :( -Olof _______________________________________________ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev
