On Thursday 01 November 2007, Josh Boyer wrote: > > > - if (dev->type != RGMII_AXON) > > > - return; > > > - > > > mutex_lock(&dev->lock); > > > > That will break 440GX boards that need to use the RGMII for data and the > > ZMII for MDIO. > > > > You may want to change the name RGMII_AXON something like RGMII_HAS_MDIO > > instead and set that for 405EX as well instead. > > And perhaps adding a comment about that since the meaning of that code > isn't very obvious. That way people that aren't the original author > of the driver don't get confused again.
Will do. I'll send a fixed version tomorrow. Best regards, Stefan _______________________________________________ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev
