On Fri, 02 Nov 2007 07:37:01 +1100 Benjamin Herrenschmidt <[EMAIL PROTECTED]> wrote:
> > On Thu, 2007-11-01 at 15:54 +0100, Stefan Roese wrote: > > This patch adds support for the 405EX to the new EMAC driver. > > > > Tested on AMCC Kilauea. > > .../... > > > diff --git a/drivers/net/ibm_newemac/rgmii.c > > b/drivers/net/ibm_newemac/rgmii.c > > index de41695..e393f68 100644 > > --- a/drivers/net/ibm_newemac/rgmii.c > > +++ b/drivers/net/ibm_newemac/rgmii.c > > @@ -140,9 +140,6 @@ void rgmii_get_mdio(struct of_device *ofdev, int input) > > > > RGMII_DBG2(dev, "get_mdio(%d)" NL, input); > > > > - if (dev->type != RGMII_AXON) > > - return; > > - > > mutex_lock(&dev->lock); > > That will break 440GX boards that need to use the RGMII for data and the > ZMII for MDIO. > > You may want to change the name RGMII_AXON something like RGMII_HAS_MDIO > instead and set that for 405EX as well instead. And perhaps adding a comment about that since the meaning of that code isn't very obvious. That way people that aren't the original author of the driver don't get confused again. josh _______________________________________________ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev
