Hi Guenter, On 09/07/2015 at 20:14:38 -0700, Guenter Roeck wrote : > > This patch introduces a new compatible string: "atmel,sama5d3-rstc" for the > > reset driver of sama5d3 and later chips. > > As in sama5d3 or later chips, we don't have to shutdown the DDR controller > > before reset. Shutdown the DDR controller before reset is a workaround to > > avoid DDR signal driving the bus, but since sama5d3 and later chips there is > > no such a conflict. > > That means: > > 1. the sama5d3 reset function only need to write the rstc register and > > return. > > 2. for sama5d3, we can remove the code related with DDR controller as we > > don't use it at all. > > > Sorry, I don't get it. Doesn't that mean there are two distinct logical > changes, which would ask for two separate patches ?
I would agree with Josh and I think that only one patch is needed. There is only one change, the removal of the workaround for sama5d3 and later. As the workaround is using a table of compatibles to remap the ram controller and the one for sama5d3 is not used because it is not needed, I think it makes sense to remove it in that same patch. The logical change here is the removal of the workaround. -- Alexandre Belloni, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
