On Fri, 2015-04-24 at 22:52 +0000, Simon Xiao wrote: > > From: Joe Perches [mailto:j...@perches.com] > > On Fri, 2015-04-24 at 11:34 -0700, six...@microsoft.com wrote: > > > From: Simon Xiao <six...@microsoft.com> > > > > > > 1. Introduce netif-msg to netvsc to control debug logging output and > > > keep msg_enable in netvsc_device_context so that it is kept > > > persistently. [] > > > diff --git a/drivers/net/hyperv/netvsc_drv.c [] > > > + if (netif_msg_probe(net_device_ctx)) > > > + netdev_dbg(net, "netvsc msg_enable: %d", > > > + net_device_ctx->msg_enable); > > > > Please use newlines to terminate formats. > > > > It helps prevent log content interleaving when multiple processes are > > emitting output at the same time. > > > > This could be shortened to use netif_<level> like: > > > > netif_dbg(net_device_ctx, probe, net, "netvsc_msg_enable: %d\n", > > net_device_ctx->msg_enable); > > > > Thanks Joe. I would like to leave this to my next patch as there are some > places else in netvsc (rndis_filter.c) > have the same usage. I would like to fix them in one patch to make them > consistent.
Oh sure no worries. It is nicer though to not introduce new formats with missing newline defects. cheers, Joe -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
