On Fri, 2015-04-24 at 11:34 -0700, six...@microsoft.com wrote:
> From: Simon Xiao <six...@microsoft.com>
>
> 1. Introduce netif-msg to netvsc to control debug logging output
> and keep msg_enable in netvsc_device_context so that it is
> kept persistently.
> 2. Only call dump_rndis_message() when NETIF_MSG_RX_ERR or above
> is specified in netvsc module debug param.
> In non-debug mode, in current code, dump_rndis_message() will not
> dump anything but it still initialize some local variables and
> process the switch logic which is unnecessary, especially in
> high network throughput situation.
[]
> diff --git a/drivers/net/hyperv/netvsc_drv.c b/drivers/net/hyperv/netvsc_drv.c
[]
> @@ -888,6 +891,11 @@ static int netvsc_probe(struct hv_device *dev,
>
> net_device_ctx = netdev_priv(net);
> net_device_ctx->device_ctx = dev;
> + net_device_ctx->msg_enable = netif_msg_init(debug, default_msg);
> + if (netif_msg_probe(net_device_ctx))
> + netdev_dbg(net, "netvsc msg_enable: %d",
> + net_device_ctx->msg_enable);
Please use newlines to terminate formats.
It helps prevent log content interleaving when multiple processes
are emitting output at the same time.
This could be shortened to use netif_<level> like:
netif_dbg(net_device_ctx, probe, net, "netvsc_msg_enable: %d\n",
net_device_ctx->msg_enable);
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
