Hi Namhyung, Namhyung Kim wrote: > On Fri, 5 Jul 2013 15:46:13 +0530, Ramkumar Ramachandra wrote: >> [3/4] introduces a util/perf-perl.h to include <perl.h> with #pragma >> statements, hence eliminating duplication. It then updates Context.xs >> and trace-event-perl.c to use this new header. > > I prefer the name being "perl.h" and use #include_next as we include the > 'util' directory in the compiler search path. > > Other than that, the change looks good to me.
Thanks for teaching me about #include_next. I'll post a re-roll shortly. >> Also, notice that feature-tests.mak has not been touched in this >> iteration: the Perl check passes without needing the #pragma >> statements (although I'm not sure why exactly). > > I guess it's because FLAGS_PERL_EMBED doesn't contain the usual perf > CFLAGS which has -Werror. Ah. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
