Hi, After Namhyung's review of the first iteration, I realized that I'd made a few mistakes. This iteration should be much better.
[1/4] is the same as before. [2/4] is new, and is used in [4/4]. [3/4] introduces a util/perf-perl.h to include <perl.h> with #pragma statements, hence eliminating duplication. It then updates Context.xs and trace-event-perl.c to use this new header. Also, notice that feature-tests.mak has not been touched in this iteration: the Perl check passes without needing the #pragma statements (although I'm not sure why exactly). Thanks. Ramkumar Ramachandra (4): perf/Makefile: do not open-code shell-sq perf/Perf-Trace-Util: fix broken include in Context.xs perf: squelch warnings from perl.h to compile-pass perf/Perf-Trace-Util: regenerate Context.c tools/perf/Makefile | 2 +- tools/perf/config/Makefile | 23 ++- tools/perf/scripts/perl/Perf-Trace-Util/Context.c | 215 +++++++++++++++++---- tools/perf/scripts/perl/Perf-Trace-Util/Context.xs | 6 +- tools/perf/util/perf-perl.h | 10 + .../perf/util/scripting-engines/trace-event-perl.c | 2 +- 6 files changed, 199 insertions(+), 59 deletions(-) create mode 100644 tools/perf/util/perf-perl.h -- 1.8.3.1.643.gebeea52.dirty -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
