On Wed, Mar 20, 2013 at 2:57 PM, Benjamin Herrenschmidt <b...@kernel.crashing.org> wrote: > On Wed, 2013-03-20 at 14:51 +0000, Grant Likely wrote: >> Both of the above problems can be worked around by using >> sysfs_create_bin_file() instead of sysfs_create_file(), but doing so >> adds an additional 20 to 40 bytes of overhead per property. A device >> tree has a lot of properties in it. That overhead will very quickly add >> up. The other option is to create a new custom sysfs attribute type >> would solve the problem without additional overhead, but at the cost of >> more complexity in the sysfs support code. However, I'm hopeful that >> these problems are just imaginary and we can stick with normal sysfs >> attributes. > > Disagreed. It would break stuff, especially the incorrect file size.
I retried with bin files. Turns out I should stop making assumptions and actually try things. It requires less code, is simpler and pretty much eliminates the issues listed above. :-) I'll post a new series with the fixes. g. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
