On Mon, 2013-02-04 at 21:56 +0530, Srikar Dronamraju wrote: > * Oleg Nesterov <o...@redhat.com> [2013-02-04 16:18:50]: > > > On 02/04, Srikar Dronamraju wrote: > > > > > > * Oleg Nesterov <o...@redhat.com> [2013-01-31 20:18:32]: > > > > > > > Move tu->nhit++ from uprobe_trace_func() to uprobe_dispatcher(). > > > > > > > > ->nhit counts how many time we hit the breakpoint inserted by this > > > > uprobe, we do not want to loose this info if uprobe was enabled by > > > > sys_perf_event_open(). > > > > > > > > > > Though I dont see a problem with this change, It seems unnecessary for > > > me. > > > > > > Info from nhits is mostly for /sys/kernel/debug/tracing/uprobe_profile > > > > It is only for uprobe_profile, yes, and it is useful. Why should we hide > > this info if this uprobe is used by perf? > > Fine with me. > > Steve, Masami, Do you have comments/suggestions on this.
I have no problem with the change. > (Since kprobe_profile just accounts for kprobetracer and doesnt account > for perf record.) > May we should make a similar change in kprobetracer to keep things > similar. I'm fine either way. -- Steve -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
