On 15/12/2025 20:33, Krzysztof Kozlowski wrote:
On 15/12/2025 19:53, David Heidelberg wrote:
Hello Lucas,
thanks for the sending Nexus 10 upstream, see few nitpicks below:
On 15/12/2025 16:05, Lukas Timmermann wrote:
From: Alexandre Marquet <[email protected]>
Manta is the code name for Google Nexus 10, and was manufactured by
Samsung with their Exynos5250 SoC.
This patch adds initial device-tree file for this board.
Signed-off-by: Alexandre Marquet <[email protected]>
Co-developed-by: Lukas Timmermann <[email protected]>
Signed-off-by: Lukas Timmermann <[email protected]>
---
arch/arm/boot/dts/samsung/Makefile | 1 +
arch/arm/boot/dts/samsung/exynos5250-manta.dts | 511
+++++++++++++++++++++++++
2 files changed, 512 insertions(+)
diff --git a/arch/arm/boot/dts/samsung/Makefile
b/arch/arm/boot/dts/samsung/Makefile
index 7becf36656b1..e0143ee8c82d 100644
--- a/arch/arm/boot/dts/samsung/Makefile
+++ b/arch/arm/boot/dts/samsung/Makefile
@@ -26,6 +26,7 @@ dtb-$(CONFIG_ARCH_EXYNOS4) += \
exynos4412-trats2.dtb
dtb-$(CONFIG_ARCH_EXYNOS5) += \
exynos5250-arndale.dtb \
+ exynos5250-manta.dtb \
exynos5250-smdk5250.dtb \
exynos5250-snow.dtb \
exynos5250-snow-rev5.dtb \
diff --git a/arch/arm/boot/dts/samsung/exynos5250-manta.dts
b/arch/arm/boot/dts/samsung/exynos5250-manta.dts
new file mode 100644
index 000000000000..0f006590576c
--- /dev/null
+++ b/arch/arm/boot/dts/samsung/exynos5250-manta.dts
@@ -0,0 +1,511 @@
+// SPDX-License-Identifier: GPL-2.0
you could use here modern SPDX I guess (GPL-2.0-only)
+/*
+ * Google Manta (Nexus 10) board device tree source
+ *
+ * Copyright (c) 2023-2025 Alexandre Marquet
+ * Copyright (c) 2025 Lukas Timmermann
+ */
+
+/dts-v1/;
+#include <dt-bindings/leds/common.h>
+#include <dt-bindings/gpio/gpio.h>
+#include <dt-bindings/clock/maxim,max77686.h>
+#include <dt-bindings/input/linux-event-codes.h>
+#include "exynos-pinctrl.h"
+#include "exynos5250.dtsi"
+#include "exynos-mfc-reserved-memory.dtsi"
+
+/ {
+ model = "Google Nexus 10";
+ compatible = "google,manta", "samsung,exynos5250", "samsung,exynos5";
+
+ aliases {
+ mmc0 = &mmc_0; /* eMMC */
+ mmc1 = &mmc_1; /* WiFi */
+ };
+
+ bmp180_vdda_reg: regulator-bmp180-vdda {
+ compatible = "regulator-fixed";
+ regulator-name = "BMP180_VDDA";
+ };
something-something-regulator (all occurences within the DTS)
I don't understand this suggestion.
oh right, let me clarify,
the regulator name should end with -regulator postfix.
+
+ bmp180_vddd_reg: regulator-bmp180-vddd {
+ compatible = "regulator-fixed";
+ regulator-name = "BMP180_VDDD";
+ };
+};
+
+&clock {
+ assigned-clocks = <&clock CLK_FOUT_APLL>;
+ assigned-clock-rates = <1000000000>;
+};
+
+&cpu0 {
+ cpu0-supply = <&buck2_reg>;
+};
+
+&ehci {
+ status = "disabled";
+};
+
+&i2c_0 {
+ status = "okay";
status should be before first sub-node (none in this case), with
preceding newline, please change all occurences
Well yeah, but do you have actually any comment pointing real issues?
No I don't, just generic device-tree nitpicks.
David
Best regards,
Krzysztof
--
David Heidelberg
