* On 3/27/21 4:58 PM, Randy Dunlap wrote: > On 3/27/21 5:01 AM, Mihai Moldovan wrote: >> + if ((-1 == index) && (index == match_start)) > > checkpatch doesn't complain about this (and I wonder how it's missed), but > kernel style is (mostly) "constant goes on right hand side of comparison", > so > if ((index == -1) &&
I can naturally send a V2 with that swapped. To my rationale: I made sure to use checkpatch, saw that it was accepted and even went for a quick git grep -- '-1 ==', which likewise returned enough results for me to call this consistent with the current code style. Maybe those matches were just frowned-upon, but forgotten-to-be-critized examples of this pattern being used. Mihai
OpenPGP_signature
Description: OpenPGP digital signature
