On Fri, Aug 16, 2019 at 12:17:09PM +0530, Bhushan Shah wrote:
> Add device-tree nodes for i2c0 to i2c2, and also add relevant pinctrl
> nodes.
>
> Suggested-by: Icenowy Zheng <icen...@aosc.io>
> Signed-off-by: Bhushan Shah <bs...@kde.org>
> ---
> Changes in v2:
>   - Add the SoC specific compatible string instead of re-using a31 one.
>
>  arch/arm64/boot/dts/allwinner/sun50i-h6.dtsi | 56 +++++++++++++++++++-
>  1 file changed, 55 insertions(+), 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/allwinner/sun50i-h6.dtsi 
> b/arch/arm64/boot/dts/allwinner/sun50i-h6.dtsi
> index bcecca17d61d..a1a329926540 100644
> --- a/arch/arm64/boot/dts/allwinner/sun50i-h6.dtsi
> +++ b/arch/arm64/boot/dts/allwinner/sun50i-h6.dtsi
> @@ -329,6 +329,21 @@
>                               function = "hdmi";
>                       };
>
> +                     i2c0_pins: i2c0-pins {
> +                             pins = "PD25", "PD26";
> +                             function = "i2c0";
> +                     };
> +
> +                     i2c1_pins: i2c1-pins {
> +                             pins = "PH5", "PH6";
> +                             function = "i2c1";
> +                     };
> +
> +                     i2c2_pins: i2c2-pins {
> +                             pins = "PD23", "PD24";
> +                             function = "i2c2";
> +                     };
> +
>                       mmc0_pins: mmc0-pins {
>                               pins = "PF0", "PF1", "PF2", "PF3",
>                                      "PF4", "PF5";
> @@ -464,6 +479,45 @@
>                       status = "disabled";
>               };
>
> +             i2c0: i2c@5002000 {
> +                     compatible = "allwinner,sun50i-h6-i2c";

This isn't going to work if you don't patch the driver to add the
compatible. And this isn't what you described in the binding patch.

Maxime

--
Maxime Ripard, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

Attachment: signature.asc
Description: PGP signature

Reply via email to