RE: [PATCH 4/4] ARM64: dts: imx: add i.MX8QXP system controller RTC support

[Anson Huang]

Best Regards!
Anson Huang

> -----Original Message-----
> From: Alexandre Belloni [mailto:alexandre.bell...@bootlin.com]
> Sent: 2018年11月28日 17:34
> To: Anson Huang <anson.hu...@nxp.com>
> Cc: Lothar Wa��mann <l...@karo-electronics.de>; a.zu...@towertech.it;
> robh...@kernel.org; mark.rutl...@arm.com; catalin.mari...@arm.com;
> will.dea...@arm.com; Aisheng DONG <aisheng.d...@nxp.com>; Andy Gross
> <andy.gr...@linaro.org>; a...@arndb.de; horms+rene...@verge.net.au;
> he...@sntech.de; bjorn.anders...@linaro.org; enric.balle...@collabora.com;
> amit.kuche...@linaro.org; ezequ...@collabora.com; o...@lixom.net;
> shawn...@kernel.org; linux-...@vger.kernel.org; devicet...@vger.kernel.org;
> linux-kernel@vger.kernel.org; linux-arm-ker...@lists.infradead.org;
> dl-linux-imx <linux-...@nxp.com>
> Subject: Re: [PATCH 4/4] ARM64: dts: imx: add i.MX8QXP system controller
> RTC support
> 
> On 28/11/2018 09:21:56+0000, Anson Huang wrote:
> > > > This module is NOT depending on any board design, should it be
> > > > enabled by
> > > default in soc dtsi?
> > > > Like wdog etc..
> > > >
> > >
> > > I guess the point is that you may not want it enabled, even if it
> > > should always be working. enabling it by default would affect the RTC
> ordering for example.
> >
> > i.MX SoCs ONLY have 1 RTC. And RTC are always enabled by default for
> > all i.MX SoCs, so do we have to disable it here and enable it in board dts?
> >
> 
> I would say that most of the i.MX based boards include another RTC because
> the SoC one consumes way too much power.
> 
> Note that I don't care too much whether it is enabled by default, I was simply
> explaining why you may want to disable it by default.

OK, this system controller RTC is a little different, it is controlled by 
system controller firmware,
and system controller firmware will always select the best one for its 
user(Linux kernel) if there are other
RTCs available, so I think we can keep it enabled by default for now. Thanks.

Anson.

> 
> --
> Alexandre Belloni, Bootlin
> Embedded Linux and Kernel engineering
> https://emea01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fbootl
> in.com&amp;data=02%7C01%7Canson.huang%40nxp.com%7C5be6d014f2a5
> 4876cc9408d65514eaf3%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C
> 0%7C636789945664646785&amp;sdata=MW0xy3cUhCLBTrEFkk4vAylxSAwB
> mx1Ws6ZeEhAsdME%3D&amp;reserved=0