RE: [PATCH 4/4] ARM64: dts: imx: add i.MX8QXP system controller RTC support

[Anson Huang]

Best Regards!
Anson Huang

> -----Original Message-----
> From: Alexandre Belloni [mailto:alexandre.bell...@bootlin.com]
> Sent: 2018年11月28日 17:20
> To: Anson Huang <anson.hu...@nxp.com>
> Cc: Lothar Waßmann <l...@karo-electronics.de>; a.zu...@towertech.it;
> robh...@kernel.org; mark.rutl...@arm.com; catalin.mari...@arm.com;
> will.dea...@arm.com; Aisheng DONG <aisheng.d...@nxp.com>; Andy Gross
> <andy.gr...@linaro.org>; a...@arndb.de; horms+rene...@verge.net.au;
> he...@sntech.de; bjorn.anders...@linaro.org; enric.balle...@collabora.com;
> amit.kuche...@linaro.org; ezequ...@collabora.com; o...@lixom.net;
> shawn...@kernel.org; linux-...@vger.kernel.org; devicet...@vger.kernel.org;
> linux-kernel@vger.kernel.org; linux-arm-ker...@lists.infradead.org;
> dl-linux-imx <linux-...@nxp.com>
> Subject: Re: [PATCH 4/4] ARM64: dts: imx: add i.MX8QXP system controller
> RTC support
> 
> On 28/11/2018 09:06:27+0000, Anson Huang wrote:
> > > > diff --git a/arch/arm64/boot/dts/freescale/imx8qxp.dtsi
> > > b/arch/arm64/boot/dts/freescale/imx8qxp.dtsi
> > > > index 9155d45..ef57db6 100644
> > > > --- a/arch/arm64/boot/dts/freescale/imx8qxp.dtsi
> > > > +++ b/arch/arm64/boot/dts/freescale/imx8qxp.dtsi
> > > > @@ -433,4 +433,8 @@
> > > >                 #size-cells = <1>;
> > > >                 ranges = <0x5f000000 0x0 0x5f000000 0x1000000>;
> > > >         };
> > > > +
> > > > +       rtc: rtc {
> > > > +               compatible = "nxp,imx8qxp-sc-rtc";
> > > > +       };
> > > >  };
> > > IMO this should be disabled by default.
> >
> > This module is NOT depending on any board design, should it be enabled by
> default in soc dtsi?
> > Like wdog etc..
> >
> 
> I guess the point is that you may not want it enabled, even if it should 
> always
> be working. enabling it by default would affect the RTC ordering for example.

i.MX SoCs ONLY have 1 RTC. And RTC are always enabled by default for all i.MX
SoCs, so do we have to disable it here and enable it in board dts?

Anson.

> 
> 
> --
> Alexandre Belloni, Bootlin
> Embedded Linux and Kernel engineering
> https://emea01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fbootl
> in.com&amp;data=02%7C01%7Canson.huang%40nxp.com%7C0586fd10d6ff4
> 5d03f4308d65512a864%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0
> %7C636789935951215703&amp;sdata=Hs1AXXoZMMKl8inOXFs8xXNXQ9EJG
> gtphyTNhFvMiTE%3D&amp;reserved=0