On Thu, Sep 20, 2018 at 03:40:55PM -0700, Ryan Case wrote:
> +static int qcom_qspi_setup(struct spi_device *spi)
> +{> + /* > + * Ensure that the configuration goes through by reading back > + * a register from the IO space. > + */ > + mstr_cfg = readl(ctrl->base + MSTR_CONFIG); Your setup() function shouldn't be affecting the status of the hardware for any other SPI devices using the controller, otherwise it might disturb an active transfer. prepare_message() is typically the best place to do this stuff. Otherwise this looks good.
signature.asc
Description: PGP signature
