On Sat, Nov 18, 2017 at 12:45:25AM +0530, Arvind Yadav wrote:
> The platform_get_irq() function returns negative if an error occurs.
> zero or positive number on success. platform_get_irq() error checking
> for zero is not correct.
>
> Signed-off-by: Arvind Yadav <arvind.yadav...@gmail.com>
> ---
> drivers/input/keyboard/twl4030_keypad.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/input/keyboard/twl4030_keypad.c
> b/drivers/input/keyboard/twl4030_keypad.c
> index f9f98ef..f94090e 100644
> --- a/drivers/input/keyboard/twl4030_keypad.c
> +++ b/drivers/input/keyboard/twl4030_keypad.c
> @@ -389,7 +389,7 @@ static int twl4030_kp_probe(struct platform_device *pdev)
> }
>
> kp->irq = platform_get_irq(pdev, 0);
> - if (!kp->irq) {
> + if (kp->irq < 0) {
kp->irq is unsigned
> dev_err(&pdev->dev, "no keyboard irq assigned\n");
> return -EINVAL;
Let's not clobber error.
> }
> --
> 2.7.4
>
--
Dmitry
