On Sat, Nov 18, 2017 at 12:45:29AM +0530, Arvind Yadav wrote: > platform_get_irq() can fail here and we must check its return value. > > Signed-off-by: Arvind Yadav <arvind.yadav...@gmail.com> > --- > drivers/input/touchscreen/sun4i-ts.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/drivers/input/touchscreen/sun4i-ts.c > b/drivers/input/touchscreen/sun4i-ts.c > index d2e14d9..2753fd3 100644 > --- a/drivers/input/touchscreen/sun4i-ts.c > +++ b/drivers/input/touchscreen/sun4i-ts.c > @@ -315,6 +315,9 @@ static int sun4i_ts_probe(struct platform_device *pdev) > return PTR_ERR(ts->base); > > ts->irq = platform_get_irq(pdev, 0); > + if (ts->irq < 0)
ts->irq is unsigned, you need to change it or use a temporary (preferable). > + return ts->irq; > + > error = devm_request_irq(dev, ts->irq, sun4i_ts_irq, 0, "sun4i-ts", ts); > if (error) > return error; > -- > 2.7.4 > Thanks. -- Dmitry
