Re: [PATCH v3 2/5] reset: socfpga: use the reset-simple driver

[Alexandru Gagniuc]

Hi Phillip,

On 08/16/2017 02:46 AM, Philipp Zabel wrote:
[snip]
@@ -118,8 +151,23 @@ static int reset_simple_probe(struct platform_device *pdev)
        data->rcdev.ops = &reset_simple_ops;
        data->rcdev.of_node = dev->of_node;
-       if (devdata)
+       if (devdata) {
+               u32 reg_offset = devdata->reg_offset;
+
+               if (reg_offset &&
+                   of_property_read_u32(dev->of_node, "altr,modrst-offset",
+                                        &reg_offset)) {
+                       dev_warn(dev,
+                                "missing altr,modrst-offset property, assuming 
0x%x!\n",
+                                reg_offset);
+               }

I would not make reading dt properties dependent on the presence of 
devdata. That breaks being able to configure the reset controller from 
dt. I would either just read the "altr,modrst-offset" property, or read 
it when

        of_device_is_compatible(dev->of_node, "altr,rst-mgr"));

Ideally, we could have a more generic "reg-offset" binding for new reset 
controllers, but that is beyond the scope of this patch.

Alex