2016-01-22 01:49+0000, Wu, Feng: >> From: Radim Krčmář [mailto:rkrc...@redhat.com] >> 2016-01-20 09:42+0800, Feng Wu: >> > - if (!kvm_intr_is_single_vcpu(kvm, &irq, &vcpu)) >> > + if (!kvm_intr_is_single_vcpu(kvm, &irq, &vcpu)) { >> > + /* >> > + * Make sure the IRTE is in remapped mode if >> > + * we don't handle it in posted mode. >> > + */ >> > + pi_set_sn(vcpu_to_pi_desc(vcpu)); >> >> What could go wrong if we didn't suppress notifications here? > > This is a good question. I also thought about this before, but after > thinking it a bit more, seems we don't need to do this. > If we don't do this, the in-flight interrupts will continue to be > delivered in PI mode while we are changing it to remapped > mode in IRTE. Even if we do this, the in-flight interrupts are > also delivered in PI mode before setting 'SN' anyway, so seems > we really don't need this, what is your opinion?
I'd remove it.
