On Sun, Apr 20, 2025 at 11:33:38PM -0700, Erni Sri Satya Vennela wrote: > Add support for speed in mana ethtool get_link_ksettings > operation. This feature is not supported by all hardware.
This needs a lot more justification. tc(1) will show you the current HTB Qdisc setting. No other MAC driver i know of will show you Qdisc info in ksettings. So why is mana special? Something your said in an earlier thread might be relevant here. There are two shaper settings involved. The Hypervisor can configure a limit, which the VM has no control over. And then you have this second limit the VM can set, which only has any effect if it is lower than the hypervisor limit. The hypervisor limit is much more like the value ksettings represents, the media speed, which is impossible to go above, and the machine has no control over. Reporting that limit in ksettings would seem reasonable. But it does not appear your firmware offers that? Andrew --- pw-bot: cr