On 22 November 2017 at 19:48, Sven Axelsson <sven.axels...@gmail.com> wrote: On 22 November 2017 at 18:10, Carl Sorensen <c_soren...@byu.edu> wrote:
Can you submit your revised .scm file as a patch? Sure! The patch also includes a change to `key-fill-translate` in define-woodwind-diagrams.scm to fill with black even for half covered holes. Personally, I don't think I have ever seen grey being used for that, but I guess it really should be made into an user settable option. Having looked some more at the documentation and code, I now realise that the gray shading indicates various trills. There are many possibilities, but one to indicate just a partially covered hole displayed in black seems to be missing. I suggest allowing the notation e.g. "one1hF" to indicate a half covered filled hole. It is currently not valid. This would need a change to `make-symbol-alist` in define-woodwind-diagrams.scm. My Scheme-fu is currently not sufficient to make that change, but I suppose I could figure it out eventually. Why not just use "one" to indicate a half-covered hole? Since there is no graphical difference between a half-filled hole and a filled hole, it seems like there does not need to be a separate notation for the half-filled whole in the input. If we had a real grob that was a woodwind diagram, we would have a 'details property for the grob with an element that would describe how to display a half-covered hole, and then one could set that property as one desired. Maybe we should create a woodwind-diagram-details property for the TextScript grob that would capture the instrument and the display characteristics (i.e., what do we do with a half-covered hole). But since it is all markups now, it seems that we just make the markup be what we want it to be. Thanks, Carl _______________________________________________ lilypond-user mailing list lilypond-user@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-user
