I can see duration vs. moment becoming a source of confusion, since these are not the same type. I would expect a property named baseDuration to take a value of type ly:duration?.
That is starting to open a can of worms, though, because the usage of duration vs. moment is inconsistent in the codebase. Arguably some of these properties that refer to spans of musical time should be changed to take values of type ly:duration? rather than of type ly:moment?. For that matter, the Scheme functions for moment arithmetic use the moment type in places where a duration would make more sense. Or maybe these don't even need to be separate types at all – I haven't looked at it deeply enough to say. Saul On Thu, Oct 3, 2024 at 9:57 PM Carl Sorensen <carl.d.soren...@gmail.com> wrote: > On Thu, Oct 3, 2024 at 5:33 PM Dan Eble <dan@lyric.works> wrote: > > > On 2024-10-03 07:38, Joram Noeck wrote: > > > You guys know much better, but I would be wondering "was it > > > baseBeatLength or beatBaseLenth"? A shorter name would be easier to > > > remember. How about > > > > > > baseLength? > > > > baseLength is vague. Is it a spatial length or a musical length? > > -- > > Dan > > > > > I also would have trouble remembering the three-word name. But as you > mention, I think length can be a physical distance. I think I'd prefer > > baseDuration > > since we've actually changed from a moment (point in time) to a duration > (interval of time). > > Carl >
