Re: New feature: automatically invert chords or drop/rise chord notes (issue 365840043 by v.villenave@gmail.com)

[dak]

https://codereview.appspot.com/365840043/diff/130001/ly/music-functions-init.ly
File ly/music-functions-init.ly (right):

https://codereview.appspot.com/365840043/diff/130001/ly/music-functions-init.ly#newcode609
ly/music-functions-init.ly:609: (let loop ((num num) (music music))
Come to think of it, using a loop here is a bad idea.  Instead an
additional count should likely be passed to the worker function in
music-functions.scm and that one called directly.  The reason is that
raising or lowering one chord note by an octave does not guarantee that
it ends up at the far end of the chord, like when using invertChords on
a c:11 chord for the fifth inversion.

https://codereview.appspot.com/365840043/

_______________________________________________
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel