Reviewers: Mark Polesky,

https://codereview.appspot.com/104520043/diff/1/Documentation/notation/notation-appendices.itely
File Documentation/notation/notation-appendices.itely (right):

https://codereview.appspot.com/104520043/diff/1/Documentation/notation/notation-appendices.itely#newcode1489
Documentation/notation/notation-appendices.itely:1489: @tab
On 2014/07/04 07:57:26, Mark Polesky wrote:
For the last two entries, this makes better sense to me:

@tab
@code{\clef tab}
@tab
@lilypond[line-width=3\cm,notime,ragged-right,relative=1]
\new TabStaff {
   \clef tab
   c1
}
@end lilypond

@item
@code{\clef moderntab}
@tab
@lilypond[line-width=3\cm,notime,ragged-right,relative=1]
\new TabStaff {
   \clef moderntab
   c1
}
@end lilypond

The problem is (else I would have done what you suggested) is that one
cannot just use

\clef moderntab { c1 } and it will print like \clef tab { c1 }, so I was
trying to show that to get that specific clef you must (so it seems) use
the \new TabStaff { .. } construct.

That maybe expected or not, but I felt it a bit misleading to not state
that you cannot use this clef in the same way as the others.

But I don't mind doing that unless anyone has any other input?

Description:
Doc: notation-appendices.itely - added 2 Clefs

Added two Clefs to A10 - Clef Styles

\clef "G2" and \clef moderntab

Please review this at https://codereview.appspot.com/104520043/

Affected files (+55, -26 lines):
  M Documentation/notation/notation-appendices.itely


Index: Documentation/notation/notation-appendices.itely
diff --git a/Documentation/notation/notation-appendices.itely b/Documentation/notation/notation-appendices.itely index bf8ac4efd7500c1f306a743859f21fa76ee86b9b..a48b0b352c8f49d9d4546f73d088f6f357ff310b 100644
--- a/Documentation/notation/notation-appendices.itely
+++ b/Documentation/notation/notation-appendices.itely
@@ -1246,14 +1246,14 @@ The following table shows all the different clef styles possible

 @multitable @columnfractions .30 .2 .30 .2

-@item
-@b{Example}
+@headitem
+Example
 @tab
-@b{Output}
+Output
 @tab
-@b{Example}
+Example
 @tab
-@b{Output}
+Output


 @item
@@ -1265,7 +1265,18 @@ The following table shows all the different clef styles possible
   { c1 }
 }
 @end lilypond
+
+@tab
+@code{\clef "G2"}
 @tab
+@lilypond[line-width=3\cm,notime,ragged-right,relative=1]
+{
+  \clef "G2"
+  { c1 }
+}
+@end lilypond
+
+@item
 @code{\clef treble}
 @tab
 @lilypond[line-width=3\cm,notime,ragged-right,relative=1]
@@ -1275,7 +1286,7 @@ The following table shows all the different clef styles possible
 }
 @end lilypond

-@item
+@tab
 @code{\clef violin}
 @tab
 @lilypond[line-width=3\cm,notime,ragged-right,relative=1]
@@ -1284,7 +1295,8 @@ The following table shows all the different clef styles possible
   { c1 }
 }
 @end lilypond
-@tab
+
+@item
 @code{\clef french}
 @tab
 @lilypond[line-width=3\cm,notime,ragged-right,relative=1]
@@ -1294,7 +1306,7 @@ The following table shows all the different clef styles possible
 }
 @end lilypond

-@item
+@tab
 @code{\clef GG}
 @tab
 @lilypond[line-width=3\cm,notime,ragged-right,relative=1]
@@ -1304,7 +1316,7 @@ The following table shows all the different clef styles possible
 }
 @end lilypond

-@tab
+@item
 @code{\clef tenorG}
 @tab
 @lilypond[line-width=3\cm,notime,ragged-right,relative=1]
@@ -1314,7 +1326,7 @@ The following table shows all the different clef styles possible
 }
 @end lilypond

-@item
+@tab
 @code{\clef soprano}
 @tab
 @lilypond[line-width=3\cm,notime,ragged-right,relative=1]
@@ -1324,7 +1336,7 @@ The following table shows all the different clef styles possible
 }
 @end lilypond

-@tab
+@item
 @code{\clef mezzosoprano}
 @tab
 @lilypond[line-width=3\cm,notime,ragged-right,relative=1]
@@ -1334,7 +1346,7 @@ The following table shows all the different clef styles possible
 }
 @end lilypond

-@item
+@tab
 @code{\clef C}
 @tab
 @lilypond[line-width=3\cm,notime,ragged-right,relative=1]
@@ -1344,7 +1356,7 @@ The following table shows all the different clef styles possible
 }
 @end lilypond

-@tab
+@item
 @code{\clef alto}
 @tab
 @lilypond[line-width=3\cm,notime,ragged-right,relative=1]
@@ -1354,7 +1366,7 @@ The following table shows all the different clef styles possible
 }
 @end lilypond

-@item
+@tab
 @code{\clef tenor}
 @tab
 @lilypond[line-width=3\cm,notime,ragged-right,relative=1]
@@ -1364,7 +1376,7 @@ The following table shows all the different clef styles possible
 }
 @end lilypond

-@tab
+@item
 @code{\clef baritone}
 @tab
 @lilypond[line-width=3\cm,notime,ragged-right,relative=1]
@@ -1374,7 +1386,7 @@ The following table shows all the different clef styles possible
 }
 @end lilypond

-@item
+@tab
 @code{\clef varC}
 @tab
 @lilypond[line-width=3\cm,notime,ragged-right,relative=1]
@@ -1384,7 +1396,7 @@ The following table shows all the different clef styles possible
 }
 @end lilypond

-@tab
+@item
 @code{\clef altovarC}
 @tab
 @lilypond[line-width=3\cm,notime,ragged-right,relative=1]
@@ -1394,7 +1406,7 @@ The following table shows all the different clef styles possible
 }
 @end lilypond

-@item
+@tab
 @code{\clef tenorvarC}
 @tab
 @lilypond[line-width=3\cm,notime,ragged-right,relative=1]
@@ -1404,7 +1416,7 @@ The following table shows all the different clef styles possible
 }
 @end lilypond

-@tab
+@item
 @code{\clef baritonevarC}
 @tab
 @lilypond[line-width=3\cm,notime,ragged-right,relative=1]
@@ -1414,7 +1426,7 @@ The following table shows all the different clef styles possible
 }
 @end lilypond

-@item
+@tab
 @code{\clef varbaritone}
 @tab
 @lilypond[line-width=3\cm,notime,ragged-right,relative=1]
@@ -1424,7 +1436,7 @@ The following table shows all the different clef styles possible
 }
 @end lilypond

-@tab
+@item
 @code{\clef baritonevarF}
 @tab
 @lilypond[line-width=3\cm,notime,ragged-right,relative=1]
@@ -1434,7 +1446,7 @@ The following table shows all the different clef styles possible
 }
 @end lilypond

-@item
+@tab
 @code{\clef F}
 @tab
 @lilypond[line-width=3\cm,notime,ragged-right,relative=1]
@@ -1444,7 +1456,7 @@ The following table shows all the different clef styles possible
 }
 @end lilypond

-@tab
+@item
 @code{\clef bass}
 @tab
 @lilypond[line-width=3\cm,notime,ragged-right,relative=1]
@@ -1454,7 +1466,7 @@ The following table shows all the different clef styles possible
 }
 @end lilypond

-@item
+@tab
 @code{\clef subbass}
 @tab
 @lilypond[line-width=3\cm,notime,ragged-right,relative=1]
@@ -1464,7 +1476,7 @@ The following table shows all the different clef styles possible
 }
 @end lilypond

-@tab
+@item
 @code{\clef percussion}
 @tab
 @lilypond[line-width=3\cm,notime,ragged-right,relative=1]
@@ -1474,7 +1486,7 @@ The following table shows all the different clef styles possible
 }
 @end lilypond

-@item
+@tab
 @code{\clef tab}
 @tab
 @lilypond[line-width=3\cm,notime,ragged-right,relative=1]
@@ -1484,6 +1496,23 @@ The following table shows all the different clef styles possible
 }
 @end lilypond

+@item
+@c @example does not work as expected within multitables
+@code{
+\new TabStaff @{ @*
+@ @ \clef moderntab @*
+@}
+}
+@tab
+@lilypond[line-width=3\cm,notime,ragged-right,relative=1]
+{
+  \new TabStaff {
+    \clef moderntab
+    { c1 }
+  }
+}
+@end lilypond
+

 @end multitable




_______________________________________________
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel

Reply via email to