On 29 nov. 2012, at 10:24, k-ohara5...@oco.net wrote: > It was Box_quarantine that seemed a confusing name. (Why 'quarantine'? > Is there something special about 40 boxes?) I take back my suggestion. > > > http://codereview.appspot.com/6827072/diff/7041/lily/box-quarantine.cc > File lily/box-quarantine.cc (right): > > http://codereview.appspot.com/6827072/diff/7041/lily/box-quarantine.cc#newcode63 > lily/box-quarantine.cc:63: TODO: not sure if this loop causes infinite > behavior... > The while(dirty) loop runs 2366 times for the last chord in > 'fingering-collision.ly' but that's an extreme case.
I'm not proud of this... > > http://codereview.appspot.com/6827072/diff/7041/lily/fingering-column.cc > File lily/fingering-column.cc (left): > > http://codereview.appspot.com/6827072/diff/7041/lily/fingering-column.cc#oldcode63 > lily/fingering-column.cc:63: fingerings[i]->translate_axis > (-fingerings[i]->extent (common[Y_AXIS], Y_AXIS).length () / 2, Y_AXIS); > This shifted all the fingerings down to align them horizontally to their > note-heads, and is missing from the new code > Fixed. > http://codereview.appspot.com/6827072/ _______________________________________________ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
