On 2010/07/07 00:52:10, Neil Puttock wrote:
Hi Carl,
This looks really good.
Thanks!
The regtests fail on beam-beat-grouping.ly, since it uses
\setBeatGrouping to
set the obsolete property beamSettings.
Dang! I know I fixed that once, but maybe I did it after running makelsr.py, and I didn't backport that fix.
The display method for \time is broken due to using ApplyContext (this
is the
same problem as issue 765 for \ottava, which I'll post my patch for
later);
you'll have to rework \time using a synthetic event so the properties
are
visible (though this can wait for a separate patch).
Yes, I have that on my to-do list. I think waiting for a separate patch makes sense. I'd love to see your patch for \ottava to help me get this right. Thanks for your thorough review! Carl http://codereview.appspot.com/1682049/show _______________________________________________ lilypond-devel mailing list lilypond-devel@gnu.org http://lists.gnu.org/mailman/listinfo/lilypond-devel
