On 12/4/09 5:27 PM, "Carl Sorensen" <c_soren...@byu.edu> wrote:
>
>
>
>
> On 12/4/09 1:31 PM, "David Kastrup" <d...@gnu.org> wrote:
>
>> Carl Sorensen <c_soren...@byu.edu> writes:
>>
>>> On 12/4/09 12:02 PM, "Han-Wen Nienhuys" <hanw...@gmail.com> wrote:
>>>
>>>> While having these explanations in mail is nice, it would be best to
>>>> put as much of possible of these comments into the code.
>>>
>>> Understood.
>>>
>>> When I see David's suggestions, I'll make sure it gets commented.
>>
>> I just came home and have to go to bed now. I'll write code tomorrow
>> that reflects the logic of your description and embeds it as well. And
>> some part of it probably will have to go into CG or similar, too.
>>
>
>
> I've put a new patch set (Set 3) that makes use of the updating in the for
> loop, as David suggested.
>
> I've eliminated the code that added the difference in script_priority values
> and just use a constant bump in outside_script_priority, which makes the
> code cleaner.
>
> I've also added comments to try to capture the intent.
>
> Reviews are welcome.
Sorry, I forgot the Rietveld link:
http://codereview.appspot.com/166057
Thanks,
Carl
_______________________________________________
lilypond-devel mailing list
lilypond-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/lilypond-devel
